Document Apache HTTP implementation namespaces - #523
Conversation
Refs #301 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fills in previously placeholder namespace documentation for Org.Apache.Http.Impl and three of its sub-namespaces, adding concise summaries plus AOSP source links and CC BY 2.5 attribution consistent with other AOSP-derived docs in the repo.
Changes:
- Replaced
To be added.placeholders with meaningful namespace<summary>text forOrg.Apache.Http.Impl,.Cookie,.Entity, and.IO. - Added
<remarks>sections linking to the corresponding AOSP source directories. - Preserved Android Open Source Project CC BY 2.5 attribution language in each updated namespace file.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/xml/ns-Org.Apache.Http.Impl.xml | Adds namespace summary and AOSP source/attribution remarks for the root Impl namespace. |
| docs/xml/ns-Org.Apache.Http.Impl.Cookie.xml | Documents the Impl.Cookie namespace summary and adds AOSP source/attribution remarks. |
| docs/xml/ns-Org.Apache.Http.Impl.Entity.xml | Documents the Impl.Entity namespace summary and adds AOSP source/attribution remarks. |
| docs/xml/ns-Org.Apache.Http.Impl.IO.xml | Documents the Impl.IO namespace summary and adds AOSP source/attribution remarks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@dalexsoto review |
1 similar comment
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
All four namespace summaries derive from Apache HttpComponents package documentation but attribute that material to AOSP under CC BY 2.5, misstating both provenance and license. Please use Apache Software Foundation / Apache License 2.0 attribution consistent with the corrected SSL namespace, retaining AOSP links only as source-location references.
Refs #301
Summary
Org.Apache.Http.Implnamespace summaries.AuthandConnnamespace files untouched because active PRs Document Apache HTTP authentication APIs #513 and Document Apache HTTP connection APIs #522 own them.Sources
Validation
System.Xml.XmlDocument.git diff --check.Org.Apache.Http.Implnamespace XML files.AuthandConnplaceholders belong to active PRs Document Apache HTTP authentication APIs #513 and Document Apache HTTP connection APIs #522.