Skip to content

Document Apache HTTP implementation namespaces - #523

Open
jonathanpeppers wants to merge 1 commit into
mainfrom
jonathanpeppers-document-apache-http-impl
Open

Document Apache HTTP implementation namespaces#523
jonathanpeppers wants to merge 1 commit into
mainfrom
jonathanpeppers-document-apache-http-impl

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Refs #301

Summary

Sources

Validation

  • Parsed all four changed XML files with PowerShell's System.Xml.XmlDocument.
  • Confirmed CRLF-only line endings in every changed XML file.
  • Ran git diff --check.
  • Verified every referenced AOSP source URL returns HTTP 200.
  • Confirmed the focused diff changes only four Org.Apache.Http.Impl namespace XML files.
  • Scoped namespace placeholders: 6 -> 2; the remaining Auth and Conn placeholders belong to active PRs Document Apache HTTP authentication APIs #513 and Document Apache HTTP connection APIs #522.

Refs #301

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 15, 2026 05:00
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 15, 2026 05:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fills in previously placeholder namespace documentation for Org.Apache.Http.Impl and three of its sub-namespaces, adding concise summaries plus AOSP source links and CC BY 2.5 attribution consistent with other AOSP-derived docs in the repo.

Changes:

  • Replaced To be added. placeholders with meaningful namespace <summary> text for Org.Apache.Http.Impl, .Cookie, .Entity, and .IO.
  • Added <remarks> sections linking to the corresponding AOSP source directories.
  • Preserved Android Open Source Project CC BY 2.5 attribution language in each updated namespace file.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docs/xml/ns-Org.Apache.Http.Impl.xml Adds namespace summary and AOSP source/attribution remarks for the root Impl namespace.
docs/xml/ns-Org.Apache.Http.Impl.Cookie.xml Documents the Impl.Cookie namespace summary and adds AOSP source/attribution remarks.
docs/xml/ns-Org.Apache.Http.Impl.Entity.xml Documents the Impl.Entity namespace summary and adds AOSP source/attribution remarks.
docs/xml/ns-Org.Apache.Http.Impl.IO.xml Documents the Impl.IO namespace summary and adds AOSP source/attribution remarks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

1 similar comment
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All four namespace summaries derive from Apache HttpComponents package documentation but attribute that material to AOSP under CC BY 2.5, misstating both provenance and license. Please use Apache Software Foundation / Apache License 2.0 attribution consistent with the corrected SSL namespace, retaining AOSP links only as source-location references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants