Document Apache HTTP cookie implementations - #527
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Closes #271 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 15, 2026 05:06
jonathanpeppers
enabled auto-merge (squash)
August 15, 2026 05:06
There was a problem hiding this comment.
Pull request overview
This PR replaces placeholder XML documentation in Org.Apache.Http.Impl.Cookie with descriptive namespace/type/member/parameter/return-value docs, aligning the generated API docs with the underlying Apache HTTP cookie implementations.
Changes:
- Replaced
To be added.placeholders across theOrg.Apache.Http.Impl.Cookienamespace. - Added/updated summaries, parameter docs, return/value docs, and binding-infrastructure (JNI peer/threshold) documentation.
- Documented cookie policies/specs (RFC 2109, RFC 2965, Netscape draft, browser-compat, best-match) and related handlers/utilities.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2965VersionAttributeHandler.xml | Replaced placeholders with docs for the RFC 2965 Version attribute handler. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2965SpecFactory.xml | Documented factory for creating RFC 2965 cookie specs. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2965Spec.xml | Documented RFC 2965 cookie parsing/validation/matching/formatting behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2965PortAttributeHandler.xml | Documented RFC 2965 Port attribute parsing/validation/matching. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2965DomainAttributeHandler.xml | Documented RFC 2965 Domain attribute parsing/validation/matching. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2965DiscardAttributeHandler.xml | Documented RFC 2965 Discard attribute handler members. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2965CommentUrlAttributeHandler.xml | Documented RFC 2965 CommentURL attribute parsing and application. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2109VersionHandler.xml | Documented RFC 2109 Version attribute parsing/validation behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2109SpecFactory.xml | Documented factory for creating RFC 2109 cookie specs. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2109Spec.xml | Documented RFC 2109 cookie parsing/validation/matching/formatting behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/RFC2109DomainHandler.xml | Documented RFC 2109 domain validation/matching rules. |
| docs/xml/Org.Apache.Http.Impl.Cookie/NetscapeDraftSpecFactory.xml | Documented factory for creating Netscape draft cookie specs. |
| docs/xml/Org.Apache.Http.Impl.Cookie/NetscapeDraftSpec.xml | Documented Netscape draft cookie spec parsing/formatting and related members. |
| docs/xml/Org.Apache.Http.Impl.Cookie/NetscapeDraftHeaderParser.xml | Documented Netscape draft header parsing API and default parser instance. |
| docs/xml/Org.Apache.Http.Impl.Cookie/NetscapeDomainHandler.xml | Documented Netscape draft domain validation/matching rules. |
| docs/xml/Org.Apache.Http.Impl.Cookie/DateUtils.xml | Documented cookie date formatting/parsing utilities and supported date patterns. |
| docs/xml/Org.Apache.Http.Impl.Cookie/DateParseException.xml | Documented exception surfaced for unparseable cookie date strings. |
| docs/xml/Org.Apache.Http.Impl.Cookie/CookieSpecBase.xml | Documented shared base behavior for parsing/matching/validating cookie specs. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BrowserCompatSpecFactory.xml | Documented factory for browser-compatible cookie specs. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BrowserCompatSpec.xml | Documented browser-compatible cookie parsing/formatting and date-pattern behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BestMatchSpecFactory.xml | Documented factory for best-match cookie spec selection. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BestMatchSpec.xml | Documented best-match policy selection and cookie parsing/validation behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicSecureHandler.xml | Documented Secure attribute parsing/behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicPathHandler.xml | Documented Path attribute parsing/validation/matching behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicMaxAgeHandler.xml | Documented Max-Age parsing and expiry-date derivation behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicExpiresHandler.xml | Documented Expires parsing into a cookie expiry date. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicDomainHandler.xml | Documented conventional Domain attribute parsing/validation/matching. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicCommentHandler.xml | Documented Comment attribute parsing/behavior. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicClientCookie2.xml | Documented RFC 2965 extensions (discard/ports/comment URL) on client cookies. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicClientCookie+InterfaceConsts.xml | Documented standard attribute-name constants used by client cookies. |
| docs/xml/Org.Apache.Http.Impl.Cookie/BasicClientCookie.xml | Documented mutable client cookie behavior, attributes, and helpers. |
| docs/xml/Org.Apache.Http.Impl.Cookie/AbstractCookieSpec.xml | Documented base cookie spec dispatch/registration model for attribute handlers. |
| docs/xml/Org.Apache.Http.Impl.Cookie/AbstractCookieAttributeHandler.xml | Documented default behavior for cookie attribute handlers (parse/match/validate). |
| docs/xml/ns-Org.Apache.Http.Impl.Cookie.xml | Documented the namespace purpose and scope. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #271 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
1 similar comment
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Org.Apache.Http.Impl.Cookie.Closes #271
Sources
Validation
To be addedplaceholders in the scoped namespace.git diff --check.