Document Apache HTTP connection schemes - #529
Open
jonathanpeppers wants to merge 1 commit into
Open
Conversation
Refs #275 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 15, 2026 05:21
jonathanpeppers
enabled auto-merge (squash)
August 15, 2026 05:21
There was a problem hiding this comment.
Pull request overview
Updates the generated XML documentation for the Org.Apache.Http.Conn.Schemes namespace by replacing “To be added.” placeholders with meaningful parameter/return/value descriptions based on AOSP sources, improving the usability of the published API docs (refs #275).
Changes:
- Filled in
<returns>/<value>documentation for key members inSchemeRegistry,Scheme, andPlainSocketFactory. - Added missing parameter descriptions and clarified a previously placeholder summary (
SchemeRegistry.SetItems).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/xml/Org.Apache.Http.Conn.Schemes/SchemeRegistry.xml | Replaces placeholder returns/values and clarifies SetItems docs for scheme registration/lookup APIs. |
| docs/xml/Org.Apache.Http.Conn.Schemes/Scheme.xml | Documents constructor parameters plus return/value semantics for core Scheme members. |
| docs/xml/Org.Apache.Http.Conn.Schemes/PlainSocketFactory.xml | Documents return/value semantics for socket creation/connection and singleton access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
1 similar comment
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #275
Sources
PlainSocketFactory.javaScheme.javaSchemeRegistry.javaSocketFactoryValidation
Org.Apache.Http.Conn.Schemes.git diff --checkand reviewed a focused three-file diff.