Document Apache HTTP connection parameters - #531
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 15, 2026 06:27
jonathanpeppers
enabled auto-merge (squash)
August 15, 2026 06:27
There was a problem hiding this comment.
Pull request overview
This PR replaces To be added. placeholders with XML documentation for types in Org.Apache.Http.Conn.Params, based on the Android API reference/AOSP sources and including the required AOSP/CC BY 2.5 attribution.
Changes:
- Adds/updates
<summary>,<param>,<returns>, and<value>documentation across theOrg.Apache.Http.Conn.ParamsXML docs. - Adds CC BY 2.5 attribution
<para>blocks in updated<remarks>sections. - Improves several API return/value descriptions (e.g.,
nullsemantics forConnRouteParamsgetters).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/xml/Org.Apache.Http.Conn.Params/IConnRoutePNames.xml | Replaces placeholders with interface/field documentation plus attribution. |
| docs/xml/Org.Apache.Http.Conn.Params/IConnPerRoute.xml | Documents method parameter and return value plus attribution. |
| docs/xml/Org.Apache.Http.Conn.Params/IConnManagerPNames.xml | Replaces placeholders with interface/field documentation plus attribution. |
| docs/xml/Org.Apache.Http.Conn.Params/IConnConnectionPNames.xml | Replaces placeholders with interface/field documentation plus attribution. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnRouteParams+InterfaceConsts.xml | Documents inherited constants summaries. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnRouteParams.xml | Documents return/value semantics and updates infrastructure-related member docs. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnRouteParamBean.xml | Replaces placeholders for parameters and infrastructure-related member docs. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnPerRouteBean.xml | Documents parameters/returns and updates infrastructure-related member docs. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnManagerParams+InterfaceConsts.xml | Documents inherited constants summaries. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnManagerParams.xml | Documents return/value semantics and updates infrastructure-related member docs. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnManagerParamBean.xml | Replaces placeholders for parameters and infrastructure-related member docs. |
| docs/xml/Org.Apache.Http.Conn.Params/ConnConnectionParamBean.xml | Replaces placeholders for parameters and infrastructure-related member docs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 15, 2026 06:38
Member
Author
|
@dalexsoto review |
1 similar comment
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
Sources
Validation