[tests] Track evaluation time across performance runs - #12390
Merged
jonathanpeppers merged 1 commit intoAug 14, 2026
Conversation
Aggregate the maximum MSBuild project evaluation duration from every profiling iteration so slow-machine detection does not depend on the final binlog. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MSBuild device integration performance tests to track the maximum MSBuild project evaluation time across all iterations in a profiling run, and uses that aggregate when deciding whether to mark a failure as “slow CI machine”.
Changes:
- Track and aggregate max
ProjectEvaluationduration acrossProfile()iterations. - Apply the same max-evaluation aggregation to
ProfileTask(). - Use aggregated max evaluation time for slow-machine classification instead of relying on only the final iteration’s binlog.
Member
Author
|
@dalexsoto review |
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 18:59
dalexsoto
approved these changes
Aug 14, 2026
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The maximum evaluation duration is now aggregated across all Profile and ProfileTask iterations, so slow-machine classification no longer depends on only the final binlog.
jonathanpeppers
deleted the
jonathanpeppers-fix-performance-evaluation-tracking
branch
August 14, 2026 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfileiterationProfileTaskFixes the valid finding in #12389 (comment).
Testing
dotnet build tests\MSBuildDeviceIntegration\MSBuildDeviceIntegration.csproj --no-restore -v:minimal -p:JavaCPath='C:\Program Files\Microsoft\jdk-17.0.16.8-hotspot\bin\javac.exe' -p:JarPath='C:\Program Files\Microsoft\jdk-17.0.16.8-hotspot\bin\jar.exe'(succeeded; 16 existing warnings, 0 errors)