Add failing NativeAOT custom configuration device test - #12451
Open
jonathanpeppers wants to merge 1 commit into
Open
Add failing NativeAOT custom configuration device test#12451jonathanpeppers wants to merge 1 commit into
jonathanpeppers wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e48442c2-2acb-4228-9eec-4b7930738a0f
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new MSBuildDeviceIntegration device regression test intended to cover NativeAOT builds/publishes using a custom “release-like” configuration name (AppStore) and validate the produced APK can be installed and launched on-device, matching the scenario from #10851.
Changes:
- Adds
NativeAOTCustomReleaseConfigurationdevice test parameterized overdotnet buildvsdotnet publish. - Uses a custom release configuration name (
AppStore) while setting Release-like MSBuild properties (Optimize=true,DebugType=None). - Installs the produced signed APK via
adband asserts the activity launches.
Suppressed comments (1)
tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs:2786
adb installoutput commonly includes additional lines (e.g., "Performing Streamed Install") before "Success". UsingAssert.AreEqual("Success", ...)can make the test fail even when install succeeded; assert that the output contains "Success" instead.
Assert.AreEqual ("Success", RunAdbCommand ($"install -r \"{apk}\"").Trim (), "APK should install.");
Comment on lines
+2757
to
+2759
| [Test] | ||
| public void NativeAOTCustomReleaseConfiguration ([Values] bool publish) | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parameterized
MSBuildDeviceIntegrationregression test for NativeAOT apps using anAppStoreconfiguration configured like Release.The test covers both
dotnet build -c AppStoreanddotnet publish -c AppStore, then installs the produced APK and verifies that the activity launches.This PR is expected to fail until the product issue is fixed. Both cases currently fail while resolving NativeAOT runtime-pack libraries derived from the custom configuration name; the existing Release NativeAOT control test passes and launches on the same device.
Fixes: #10851