Run ilverify via the tool manifest instead of a hard-coded cache path - #20101
Merged
Conversation
Contributor
✅ No release notes required |
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
abonie
force-pushed
the
fix/ilverify-net11-tool-bump
branch
from
July 30, 2026 09:15
d47d32e to
7d3dc45
Compare
abonie
changed the title
abonie
force-pushed
the
fix/ilverify-net11-tool-bump
branch
from
July 30, 2026 09:34
7d3dc45 to
bf146aa
Compare
abonie
changed the title
The EmittedIL IL-verification tests ran ilverify by exec'ing a hard-coded NuGet cache path ({NUGET_PACKAGES}/dotnet-ilverify/9.0.0/tools/net9.0/any/ILVerify.dll). On the net11 CI SDK that guessed path was not populated after `dotnet tool restore`, so ~215 EmittedIL tests failed with a missing ILVerify.dll.
Invoke the tool through the local manifest with `dotnet tool run ilverify` so the SDK resolves it wherever it was restored, independent of the NuGet cache layout, tool version, or target framework.
Verified on the net11 SDK (11.0.100-preview.6) with the existing pinned tool: the previously failing Regression_Specialize_ConstraintVerification tests pass 16/16.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 422b6203-341b-4e72-8f93-9d6da463addc
abonie
force-pushed
the
fix/ilverify-net11-tool-bump
branch
from
July 30, 2026 10:16
bf146aa to
02133c8
Compare
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
T-Gro
approved these changes
Jul 30, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
Bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EmittedIL IL-verification tests ran ilverify by exec'ing a hard-coded NuGet cache path (
{NUGET_PACKAGES}/dotnet-ilverify/9.0.0/tools/net9.0/any/ILVerify.dll). On the net11 CI SDK that guessed path was not populated afterdotnet tool restore, so ~215 EmittedIL tests failed with a missingILVerify.dll.Invoke the tool through the local manifest with
dotnet tool run ilverifyso the SDK resolves it wherever it was restored, independent of the NuGet cache layout, tool version, or target framework.Verified on the net11 SDK (11.0.100-preview.6) with the existing pinned tool: the previously failing
Regression_Specialize_ConstraintVerificationtests pass 16/16.