Skip to content

Add Pixel 10a mobile performance coverage - #5284

Open
LoopedBard3 wants to merge 3 commits into
dotnet:mainfrom
LoopedBard3:loopedbard3-add-pixel-10a-tests
Open

Add Pixel 10a mobile performance coverage#5284
LoopedBard3 wants to merge 3 commits into
dotnet:mainfrom
LoopedBard3:loopedbard3-add-pixel-10a-tests

Conversation

@LoopedBard3

@LoopedBard3 LoopedBard3 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

  • add Pixel 10a to all existing Pixel SDK/MAUI performance test matrices
  • run the runtime Android JIT, static-linking, and R2R variants on Pixel 10a
  • map the new queue to the Pixel10a device name while preserving Pixel 8 coverage

Testing

  • parsed the changed YAML files
  • validated Python syntax and Pixel 8/Pixel 10a matrix parity

Internal Run: https://dev.azure.com/dnceng/internal/_build/results?buildId=3052379&view=results

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 19, 2026 22:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the repo’s mobile performance infrastructure to include Pixel 10a alongside existing Pixel coverage by introducing a new Helix queue mapping and wiring a machinePool value through pipeline/job matrices.

Changes:

  • Added a new logical-machine → Helix queue mapping for perfpixel10a and treated the new Pixel 10a queue as a mobile queue for device-name env var handling.
  • Updated Helix/pipeline templates and matrices to pass machinePool (e.g., Pixel8, Pixel10a) and schedule Pixel 10a runs across existing SDK/MAUI matrices.
  • Refactored runtime Android perf jobs to iterate over a configurable androidMachines list (Pixel + Pixel 10a).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/run_performance_job.py Adds Pixel 10a queue mapping and includes the queue in mobile DEVICE_NAME handling.
helix.yml Adds machinePool variable and a Pixel 10a profile that passes --machine-pool.
eng/pipelines/templates/run-performance-job.yml Updates the machinePool parameter comment to include Pixel 10a.
eng/pipelines/templates/build-machine-matrix.yml Adds a private-build machine matrix entry for Pixel 10a with machinePool: Pixel10a.
eng/pipelines/sdk-perf-jobs.yml Adds the Pixel 10a machine to multiple existing SDK scenario matrices.
eng/pipelines/runtime-perf-jobs.yml Introduces androidMachines and loops Android runtime perf jobs over Pixel + Pixel 10a.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/pipelines/runtime-perf-jobs.yml Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 19, 2026 22:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (2)

eng/pipelines/templates/build-machine-matrix.yml:137

  • The comment says "Windows ARM64 Pixel 10a", but this matrix entry is using archType: x64 and vmImage: windows-2022 (Windows x64 host) and targets an Android ARM64 device. This can mislead future edits/debugging.
- ${{ if and(containsValue(parameters.buildMachines, 'win-x64-android-arm64-pixel10a'), not(eq(parameters.isPublic, true))) }}: # Windows ARM64 Pixel 10a only used in private builds currently

scripts/run_performance_job.py:1151

  • The Pixel 10a DEVICE_NAME special-case is unnecessarily tied to both logical_machine and the queue string. If a Pixel 10a run is configured via --queue Windows.11.Amd64.Pixel.10.Perf (without --logical-machine/--machine-pool), DEVICE_NAME will not be set even though this queue is treated as a mobile queue below.
    # Pixel 10a runtime jobs use a logical machine rather than a machine pool.
    if args.logical_machine == "perfpixel10a" and args.queue == "Windows.11.Amd64.Pixel.10.Perf":
        args.run_env_vars["DEVICE_NAME"] = "Pixel10a"
    elif args.machine_pool and args.queue and args.queue in (
        "Windows.11.Amd64.Pixel.Perf",

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 19, 2026 22:34
@LoopedBard3 LoopedBard3 self-assigned this Aug 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants