Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3009486#129431

Open
dotnet-bot wants to merge 13 commits into
mainfrom
locfiles/624e090a-942d-409d-8334-8559cd3f3a1d
Open

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3009486#129431
dotnet-bot wants to merge 13 commits into
mainfrom
locfiles/624e090a-942d-409d-8334-8559cd3f3a1d

Conversation

@dotnet-bot

Copy link
Copy Markdown
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@github-actions

This comment has been minimized.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3000801 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3000847 Jun 15, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3000847 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3000940 Jun 15, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3000940 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3000999 Jun 15, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3000999 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001015 Jun 15, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001015 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001068 Jun 15, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001068 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001088 Jun 15, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001088 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001109 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001109 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001157 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001157 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001176 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001176 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001187 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001187 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001210 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001210 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001372 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001372 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001382 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001382 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001400 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001400 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001562 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001562 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001579 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001579 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001600 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001600 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001685 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001685 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001771 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001771 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3001820 Jun 16, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3002927 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3002965 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3002965 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003013 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003013 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003026 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003026 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003070 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003070 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003086 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003086 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003160 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003160 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003181 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003181 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003203 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003203 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003218 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003218 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003238 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003238 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003259 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003259 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003276 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003276 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003443 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003443 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003458 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003458 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003511 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003511 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003523 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003523 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003534 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003534 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003545 Jun 18, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003545 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003622 Jun 19, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003622 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003639 Jun 19, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003639 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003657 Jun 19, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003657 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3003668 Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Copilot Code Review

Holistic Assessment

Motivation: Automated OneLocBuild PR syncing localized .xlf translation files. Standard localization pipeline process for 39 files across three libraries.

Approach: Removes obsolete translation entries, adds new state="new" entries for the downstream translation pipeline, and updates source text for entries with changed English strings.

Summary: ⚠️ Needs Human Review. The System.Runtime.InteropServices changes (13 files) are correctly in sync with main. However, the Microsoft.Extensions.Logging.Abstractions (13 files) and System.Text.Json (13 files) changes reflect a future state of source strings that has not yet landed on main. A human reviewer familiar with the OneLocBuild pipeline should confirm whether the corresponding .resx updates will land before or alongside this PR.


Detailed Findings

Detailed Findings

✅ System.Runtime.InteropServices — Correctly in sync with main

Verified the .resx on main (SHA d6c7fb69f882c3ffd49de58dd009330e2a915402):

  • The 3 removed InstancePropertyDeclaredInInterface* entries are absent from the current .resx (removed by PR Add support for properties in COM source generator #128869).
  • All 12 new entries (InvalidPropertyDeclarationOnGeneratedComInterface*, MarshalAttributeOnDefaultImplementedComInterfaceMember*, MarshalUsingOnPropertyAccessorMustSpecifyType*, PropertyAccessorsMustBeAllOrNothing*) are present in the current .resx.
  • Source text in each new .xlf entry matches the .resx values exactly.

⚠️ Microsoft.Extensions.Logging.Abstractions — Version skew with main

The .resx on main still contains entries being removed from .xlf, and source text changes don't match:

Issue Details
Entries removed from .xlf but still in .resx InvalidLoggingMethodParameterOut*, InvalidLoggingMethodParameterParams*, InvalidLoggingMethodParameterRefStruct*, LoggingMethodHasAllowsRefStructConstraintMessage, LoggingUnsupportedLanguageVersion*, MalformedFormatStringsTitle, PrimaryConstructorParameterLoggerHidden*, ShouldntReuseEventNames*
New entry not in .resx LoggingMethodIsGenericMessage
Source text mismatch .resx says must be 'partial' / must return 'void' / must be 'static' (with quotes); .xlf changes to must be partial / must return void / must be static (without quotes)
Also changed MalformedFormatStringsMessage source text changed; RedundantQualifierInMessageMessage single-quotes removed

The last commit to this .resx on main (Feb 27, 2026, PR #124960) added these quotes to improve translation quality. The OneLocBuild pipeline appears to be running against a build that reverses this change.

⚠️ System.Text.Json — Version skew with main

The .resx on main still contains all entries being removed from .xlf:

Issue Details
Entries removed from .xlf but still in .resx DerivedJsonConverterAttributesNotSupported*, FastPathPolymorphismNotSupported*, JsonConverterAttributeInvalidType*, JsonIgnoreConditionAlwaysInvalidOnType*, JsonSerializableAttributeOnNonContextType*, JsonStringEnumConverterNotSupported*, JsonUnsupportedLanguageVersion*, OpenGenericDerivedTypeCouldNotBeResolved*, Polymorphism_OpenGeneric_Reason_* (5 entries), TypeContainsRefLikeMember*, UnionCaseTypesNotClassifiable*, UnionTypeShapeNotSupported*
New entries not in .resx InitOnlyPropertyDeserializationNotSupportedFormat, InitOnlyPropertyDeserializationNotSupportedTitle
Source text mismatch DuplicateTypeNameMessageFormat: .resx says named '{0}' (with quotes); .xlf changes to named {0} (without quotes)

✅ Structural consistency across language files

All changes are applied identically across all 13 language-specific .xlf files for each library. New entries correctly use state="new" with English source text as target (standard OneLocBuild pattern).

Note

This review was generated by Copilot.

Generated by Code Review for issue #129431 · ● 42.3M ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant