[cDAC] ArgIterator stress validation: enable byte-identical GCRefMap blobs across x64/x86 and wire ARGITER sub-check into Helix#129769

Merged

max-charlamb merged 40 commits into

dotnet:mainfrom

max-charlamb:cdac-shared-argiterator

Jun 27, 2026

Commits on Jun 23, 2026

Move ArgIterator and TransitionBlock to tools/Common/CallingConvention

Max Charlamb
and
Copilot
committed
Introduce ITypeHandle interface and extract TypeHandle to own file

Max Charlamb
and
Copilot
committed
Move TypeHandle to crossgen2 project directory

Max Charlamb
and
Copilot
committed
Move shared CallingConvention to Internal.Runtime.CallingConvention namespace and remove TypeSystemContext dependency

Max Charlamb
and
Copilot
committed
Eliminate TypeSystem deps, add CallingConvention contract with CdacTypeHandle adapter

Max Charlamb
and
Copilot
committed
Add CallingConvention contract with GCDesc-based value type GC ref enumeration

Max Charlamb
and
Copilot
committed
Refactor ICallingConvention to be GC-agnostic and wire into GcScanner

Max Charlamb
and
Copilot
committed
WIP: dump test for CallingConvention vs GCRefMap + NotImplementedException frame skip

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 1: ArgIterator sub-check + restructure DOTNET_CdacStress

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 2: wire ComputeCallRefMap as the runtime oracle

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 3-5: ArgIterator encoder, pretty-print FAILs, ByRef/array/generic fixes

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 5: encode by-value structs containing GC pointers

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 6: resolve both VAR and MVAR via combined generic context

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 7: enable x86 in the GCRefMap encoder

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 7.1: x86 ARG_FAIL pretty-print + GetCbStackPop hardening

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 7.2: propagate OutermostKind into CdacTypeHandle so x86 ArgIterator classifies PTR / BYREF / SZARRAY args correctly

Max Charlamb
and
Copilot
committed
[cdac stress] Phase 8: implement IsTrivialPointerSizedStruct for x86 register passing

Max Charlamb
and
Copilot
committed
cDAC RuntimeTypeSystem: add IsByRefLike and GetFieldDescApproxTypeHandle

Max Charlamb
and
Copilot
committed
cDAC CallingConvention: support ByRefLike struct args and nested value types

Max Charlamb
and
Copilot
committed
cDAC stress: nested-struct scenario + CallSignatures debuggee

Max Charlamb
and
Copilot
committed
cDAC CallingConvention: normalize value-type args via GetInternalCorElementType

Max Charlamb
and
Copilot
committed
cDAC CallingConvention: emit VASigCookie token for vararg methods

Max Charlamb
and
Copilot
committed
cDAC stress: add ARGITER theory + machine-readable [GC_STATS] marker

Max Charlamb
and
Copilot
committed
cDAC stress CI: add windows_x86 to the stress test matrix

Max Charlamb
and
Copilot
committed

Commits on Jun 24, 2026

cDAC stress: tolerate ARG_SKIP and route unsupported archs there

Max Charlamb
and
Copilot
committed
cDAC stress: catch NotImplementedException across the whole encoder

Max Charlamb
and
Copilot
committed
cDAC stress: new CrossModule debuggee covering cross-module type refs

Max Charlamb
and
Copilot
committed
Address PR review feedback from copilot-pull-request-reviewer

Max Charlamb
and
Copilot
committed
cDAC stress: scope ARGITER theories to windows-x86/x64, split out VarArgs

Max Charlamb
and
Copilot
committed
cDAC stress: consolidate VarArgs into WindowsOnlyDebuggees, rename GCStress -> GCRefStress

Max Charlamb
and
Copilot
committed
Address PR review feedback: narrow surface, redesign wire format, fold builder

Max Charlamb
and
Copilot
committed
Address PR review feedback round 3

Max Charlamb
and
Copilot
committed

Commits on Jun 25, 2026

Stress tests: add CrossModule to xunit list; exclude VarArgs from GCREFS

Max Charlamb
and
Copilot
committed
ArgIterator: require objectTypeHandle/intPtrTypeHandle/isWindows

Max Charlamb
and
Copilot
committed
ArgIterator: make generic over TTypeHandle to avoid boxing

Max Charlamb
and
Copilot
committed
CallingConvention_1: fold GetCbStackPop into GetArgumentLayout

Max Charlamb
and
Copilot
committed
Address PR review feedback round 4 (Copilot follow-up)

Max Charlamb
and
Copilot
committed

Commits on Jun 26, 2026

Final polish: misleading comment, README rename, Helix chmod

Max Charlamb
and
Copilot
committed
CdacTypeHandle: promote _arch field to public Arch property

Max Charlamb
and
Copilot
committed

Commits on Jun 27, 2026

cdacstress: fix gcc -Werror=address and -Werror=format-truncation

Max Charlamb
and
Copilot
committed