Skip to content

Add HttpMethod.Query to static method test data #129790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicoAvanzDev wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Add HttpMethod.Query to static method test data #129790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd603b6
Add HttpMethod.Query to static method test data
NicoAvanzDev Jun 24, 2026
8580058
Merge branch 'main' into httpmethod-query-test-data
NicoAvanzDev Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Net.Http/tests/FunctionalTests/HttpMethodTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ static HttpMethodTest()
new object[] { HttpMethod.Delete },
new object[] { HttpMethod.Head },
new object[] { HttpMethod.Options },
new object[] { HttpMethod.Trace }
new object[] { HttpMethod.Trace },
new object[] { HttpMethod.Query }
Comment on lines 21 to +25

@MihaZupan MihaZupan Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment looks right.

If we're already making changes here, mind making StaticHttpMethods a List<HttpMethod> instead, then using it in all tests in this file?
There's no point listing out the same list 3 times like is done currently, and the AddStaticHttpMethods helper doesn't make sense either.

};
AddStaticHttpMethods(staticHttpMethods);
StaticHttpMethods = staticHttpMethods;
Expand Down
Loading