JIT/wasm: keep EH frame slots at the bottom after frame alignment#129917
Open
AndyAyersMS wants to merge 1 commit into
Open
JIT/wasm: keep EH frame slots at the bottom after frame alignment#129917AndyAyersMS wants to merge 1 commit into
AndyAyersMS wants to merge 1 commit into
Conversation
dotnet#129815's alignment padding displaced the fixed-offset wasm EH slots and broke EH dispatch. Shift them down past the pad. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Member
Author
|
@davidwrighton ptal |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This change updates the WASM-specific frame-alignment logic in Compiler::lvaAlignFrame() to preserve the fixed-at-frame-bottom placement of the WASM EH-related frame slots even when alignment padding is added.
Changes:
- Compute the WASM alignment padding (
pad) without immediately mutatingcompLclFrameSize. - When padding is applied, shift the WASM EH slot locals (
lvaWasmFunctionIndex,lvaWasmVirtualIP,lvaWasmResumeIP) down bypadso their effective final FP-relative offsets remain unchanged. - Keep the existing invariant that the resulting local frame size is
STACK_ALIGN-aligned.
davidwrighton
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#129815's alignment padding displaced the fixed-offset wasm EH slots and broke EH dispatch. Shift them down past the pad.