Skip to content

Fix X509 reference leak in SslStream extra chain certificates on Unix #132351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glima wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Fix X509 reference leak in SslStream extra chain certificates on Unix #132351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/native/libs/System.Security.Cryptography.Native/pal_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,13 @@ int32_t CryptoNative_SslAddExtraChainCert(SSL* ssl, X509* x509)
return 0;
}

if (SSL_ctrl(ssl, SSL_CTRL_CHAIN_CERT, 1,(void*)x509) == 1)
// larg must be 0 (SSL_add0_chain_cert), not 1 (SSL_add1_chain_cert). The caller,
// Interop.Ssl.AddExtraChainCertificates, up-refs and then calls SetHandleAsInvalid to
// hand its reference over, which is the add0 contract and matches
// CryptoNative_SslCtxAddExtraChainCert above. With add1 libssl takes a reference of its
// own and the caller's is abandoned rather than released, leaking one X509 per
// intermediate per SSL handle.
if (SSL_ctrl(ssl, SSL_CTRL_CHAIN_CERT, 0,(void*)x509) == 1)
{
return 1;
}
Expand Down
Loading