Add reaction_added support and conversations.history#34
Open
murdahl wants to merge 2 commits into
Open
Conversation
Introduce handling for Slack reaction_added events and add Conversations.history support. - Add ReactionAddedEvent model and ReactionItem, plus IHandleReactionAdded abstraction. - Register ReactionAdded middleware and handler builder integration (IAppBuilderExtensions, SlackBotHandlersBuilder, ISlackbotHandlersBuilder, HttpItemsManager routing/deserialization). - Add ConversationsHistory API to ISlackClient and SlackClient, with ConversationsHistoryResponse model; include cursor handling. - Extend ConversationsRepliesResponse.Message to include bot-related fields (SubType, Bot_Id, Bot_Profile) for proper bot-message deserialization. - Add unit tests and a StubHttpMessageHandler to verify bot-message deserialization and ConversationsHistory pagination. These changes enable processing of reaction_added events and correctly deserialize bot/app-authored messages from conversation endpoints.
Remove the unreliable SubType property from the ConversationsReplies Message model, add App_Id, and clarify that Bot_Id is the reliable bot detector. Update tests to stop asserting SubType and add a new test covering an app/bot message shape (bot_id + app_id, user present, no bot_profile). Also adjust existing tests to reflect the model change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Want to play with reactions ✌️ Could do some sort of integrated voting thing
Also added bot tracking in conversation history, as I can't reliably get that from app.mentions.
Ended up with a app to app conversation with non stop responding to each other.
Introduce handling for Slack reaction_added events and add Conversations.history support.
These changes enable processing of reaction_added events and correctly deserialize bot/app-authored messages from conversation endpoints.