Coordinate combat logging and instrument Mythic+ startup - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LibCombatLogging-1.0when it is already available in the WoW addon environment, without depending on Raider.IO itselfLoggingCombatAPI when the library is unavailableLibCombatLogginghandles and start/stop callbacks without calling the native logging API just for diagnosticsWhy
A real failing session showed that the first Mythic+ started while physical combat logging was off and logging resumed only after the run had already begun. The desktop reader/parser cannot recover a
CHALLENGE_MODE_STARTthat WoW never wrote.This change removes a possible ownership conflict from our bootstrap and gives the next failing session enough passive diagnostics to distinguish:
No direct dependency on Raider.IO is introduced; the library is capability-detected at runtime.