refactor: replace comment read receipts with per-task cursors - #659
Open
b0ink wants to merge 13 commits into
Open
refactor: replace comment read receipts with per-task cursors#659b0ink wants to merge 13 commits into
b0ink wants to merge 13 commits into
Conversation
- this allows for a mix of student comments and automated comments - tasks with student comments show up in inbox, and ignores automated comments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Actual unit 12 measurements:
TODO: Automated comments break this cursor design - OnTrack should have a "SYSTEM" user account that all automated comments send from. Eg. overseer assessment reports, task status updates (only automated task status updates?), project plan comments? anything that currently automatically gets marked as read by the receipient should be from the SYSTEMTask comments now have a "audience" field, used to identify who the comment is intended for. "Students" are the audience for automated comments, "noone" for status updates, and either "staff" or "students" for text comments depending on the recipient. This allows the comment cursor to display up to a student's text comment, and the inbox will ignore any status updates, project plan changes, overseer assessments that would otherwise normally be marked as read by all parties