iOS: per-group accordions in song Recordings section#191
Merged
Conversation
The outer DisclosureGroup around the whole Recordings section is gone — the section is always visible, no chevron at the top. In its place, each grouping shelf (decade when sorted by year, artist name when sorted by name) is now its own collapsible row that starts closed. First view of a song now shows a scannable list of "1960s (12)", "1970s (8)", … or "Miles Davis (4)", "John Coltrane (3)", … with the items hidden until the user taps to open a shelf. Expansion state lives in a Set<String> keyed by group name, so filter changes preserve per-shelf state for keys that still exist and naturally drop keys that don't. Switching sort order rebuilds the keyspace entirely (decades to artist names), so the set is cleared in that case. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set<String>keyed by group name; switching sort order clears it (since decade keys and artist-name keys don't overlap), filter changes preserve it for any surviving keys.Test plan
🤖 Generated with Claude Code