Fix benchmark bar chart scale on mobile - #555
Open
worldsoup wants to merge 1 commit into
Open
Conversation
The fixed 90px/170px side columns left almost no room for the actual bar track on narrow viewports (down to ~51px). Below 480px, shrink those columns, stack the value/relative labels vertically to reclaim horizontal space, and reduce a few font sizes accordingly. Also shortens "operations / second" to "ops/second" under the axis. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Summary by QodoFix Benchmark bar chart scale on mobile
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmarkcomponent's bar rows used fixed90px/170pxside columns, which on narrow viewports left the actual bar track only ~51px wide — the chart looked broken/squished on mobile.64px/76px, stack the ops-value and relative-speed labels vertically instead of side-by-side, and scale down a few font sizes to fit without wrapping or overflowing.Test plan
10,250,000) — no text overflow/wrapping, bar track grew from 51px to ~187px.tsc --noEmitandyarn docusaurus buildboth pass clean against latestmain.🤖 Generated with Claude Code