Repository navigation
Keep the page behind a modal from scrolling on touch - #409
Merged
Merged
Conversation
iOS Safari ignores overflow: hidden on the root for touch scrolling, so a drag on an open drawer's backdrop or header scrolled the page behind it, collapsed the toolbar, and slid the drawer off screen. Refuse touch moves while a modal is open unless they land in a scroller inside it that can move along the gesture, and contain overscroll in those scrollers so they don't chain to the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iOS Safari the page behind an open modal (e.g. the Insights finding drawer) still scrolls by touch. `html:has(dialog[open]) { overflow: hidden }` covers wheel/trackpad, but iOS ignores root overflow for touch scrolling. A drag on the drawer header or backdrop scrolls the document, the toolbar collapses, and the drawer slides off with the page.
Fix
I chose this over pinning `` with `position: fixed` because that breaks `position: sticky` (`.mobile-header`, the replica banner) behind centered modals and has to restore the scroll offset afterward.
Tests
No visual change, so there are no before and after screenshots.