revert: optmization test - #216
Merged
Merged
Conversation
The UI ships every rule inside its JS (webpack style-loader) and injects them as separate <style> tags at runtime — 92 live on a loaded desk, ~200 over a longer session. This page therefore links no application CSS at all. That is expensive at render time, not just at load: Chrome consults one RuleSet per stylesheet for every element it restyles, so a ~5,800-element recalculation performed well over a million rule-set consultations. Measured on production 2026-09-11 at 12-30us per element, against well under 1us for a normal document, and 33.4s of style recalculation in a single session. The UI side now extracts one merged `styles.<hash>.css` and lists it in the same manifest.json these bundles already come from, so this only has to read one more key and emit one more <link>. OPTIONAL BY DESIGN, so this is safe to deploy on its own and should go FIRST: a UI build that predates the change has no `styles.css` key, `data.styles` is null, the guard in index.tpl emits nothing, and the runtime <style> injection keeps working exactly as it does today. The non-manifest branch never sets the key at all, which the template also tolerates. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Links the app stylesheet emitted by ui-team's perf/css-single-stylesheet build. Optional by design: with a UI build that has no styles.css in its manifest this changes nothing, so it is safe ahead of the UI deploy — and must land first, since the reverse order renders the app unstyled.
|
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.