fix(signup): enforce the password policy on create_account - #241
Merged
Merged
Conversation
The rules (8+ chars, uppercase, number, symbol) lived only in the signup
UI, so a direct call to signup.create_account could set any password.
Checked on the trimmed value — the one that is hashed and that login
compares — and rejected with {status: "weak_password", missing: [keys]},
keys matching the UI's PW_NEEDS_* locale keys.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rules (8+ chars, uppercase, number, symbol) lived only in the signup UI, so a direct call to signup.create_account could set any password. Checked on the trimmed value — the one that is hashed and that login compares — and rejected with {status: "weak_password", missing: [keys]}, keys matching the UI's PW_NEEDS_* locale keys.