Repository navigation
fix(media): a hub admin's workspace rename reaches every member - #244
Merged
Merged
Conversation
media.rename on a hub only renamed the caller's desk row and pushed to the caller's sockets, so other members never saw the new name — and the dest it built for any recipient was read from the caller's db. When the caller is admin on the hub (user_permission & ADMIN), rename now calls yp.hub_rename_for_members, reads each member's node back from THEIR db, and pushes to entity_sockets(hub_id). Below admin it stays a personal rename. If the shared step fails, the caller's own rename still answers. Needs yp.hub_rename_for_members (schemas fix/workspace-rename-sync). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
EddyOne81
pushed a commit
that referenced
this pull request
Oct 12, 2026
media.rename on a hub only renamed the caller's desk row and pushed to the caller's sockets, so other members never saw the new name — and the dest it built for any recipient was read from the caller's db. When the caller is admin on the hub (user_permission & ADMIN), rename now calls yp.hub_rename_for_members, reads each member's node back from THEIR db, and pushes to entity_sockets(hub_id). Below admin it stays a personal rename. If the shared step fails, the caller's own rename still answers. Needs yp.hub_rename_for_members (schemas fix/workspace-rename-sync). Co-authored-by: Drumee Dev <drumee@debian.local.drumee> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 4085ea4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
media.rename on a hub only renamed the caller's desk row and pushed to the caller's sockets, so other members never saw the new name — and the dest it built for any recipient was read from the caller's db.
When the caller is admin on the hub (user_permission & ADMIN), rename now calls yp.hub_rename_for_members, reads each member's node back from THEIR db, and pushes to entity_sockets(hub_id). Below admin it stays a personal rename. If the shared step fails, the caller's own rename still answers.
Needs yp.hub_rename_for_members (schemas fix/workspace-rename-sync).