Repository navigation
Feat/chat details panel - #245
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The media table stores no duration, so the Chat details Videos page had none. For kind=video, rows without a duration read <hub home>/__storage__/<nid>/info.json (orig.format.duration, ffprobe), rounded to seconds; null when absent/unreadable. The nid must be a plain id, so the read never leaves __storage__. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Chat details for a DIRECT conversation:
- chat.p2p_details {peer_id}: media counts from both participants'
p2p_channel (p2p_media_stats in the viewer's DB, like p2p_list_messages)
and the two participants with presence (yp drumate_presence).
- chat.p2p_media_list {peer_id, kind, page}: rows carry their own hub_id;
a video's missing duration is read from that hub's info.json.
The info.json reader moves to service/lib/media-duration.js, shared with
channel.media_list.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ation partner Any authenticated caller could walk peer ids and read each user's email, online flag and last-seen through p2p_details. The peer now counts only when the viewer has them as a contact or has a conversation with them (p2p_time holds one row per partner, either side wrote); otherwise the panel gets the viewer alone and no media. drumate_presence keeps its arity (shared stage yp). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e_state) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…t, worker p2p mode) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
this.db is the DB of the hub the request names. A caller with write on someone else's shared folder could name that hub and read or export the owner's DMs with a contact. _p2pRelated (p2p_details, p2p_media_list, p2p_export_scope, p2p_export) now refuses unless the hub is the caller's. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… on messages/post) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… in SQL - channel.acknowledge with topic_id (the team chat reads on interaction): channel_topic_mark_read only, never the hub read_channel cursor that would mark General and other topics read; a message outside the topic is refused. - messages topic_id=general → channel_general_messages (full SQL pages). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.