docs: drop workspace-path assumption from plugin docs and skills#332
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates various documentation and skill files to remove absolute paths referencing ${GIT_HOME_PUBLIC} and replace them with relative paths or context-aware instructions, aligning the documentation with a more flexible workspace layout. The feedback suggests removing a redundant git switch main command when syncing from the main worktree, as the main branch is already checked out in that directory.
7a9729e to
32b4137
Compare
PR #330 swapped hardcoded `~/git/...` for `${GIT_HOME_PUBLIC}/<repo>/...`. Reviewer follow-up: skill docs should not bake a workspace path convention into prose either — describe what to do, not where files live. Changes (10 files): - .claude/rules/worktree-conventions.md: convention table now shows relative paths (`<repo>/main/`, `<repo>/{branch-name}/`). Operational "switch to main and sync" line drops the `cd`, says "From the main worktree, sync". - git-standards/skills/git-workflow-standards/SKILL.md: layout diagram + table use relative paths. Create/Remove commands use `../` from the main worktree. - git-workflows/skills/sync-main: "find and sync main" describes the worktree role; drops `cd`. - git-workflows/skills/troubleshoot-worktree: `git worktree add ../<branch>` (relative). - github-workflows/skills/rebase-pr: "from the main worktree" framing. - github-workflows/skills/refresh-repo: drops the `${GIT_HOME}/CLAUDE.md` citation (just "per the workspace convention"); drops the `${GIT_HOME_PUBLIC}/<repo>/<default>/` path-resolution rule in favor of `git worktree list --porcelain` matching on `branch refs/heads/<default>`; --sweep glob description loosened. - infra-orchestration/orchestrate-infra: "locate each target repo's main worktree" instead of a path glob. - infra-orchestration/sync-inventory: "from the X main worktree" framing; repo list shows names only, not paths. - infra-orchestration/test-e2e: same. - codeql-resolver/README.md: examples annotate the worktree, drop `cd`. The `${GIT_HOME}` / `${GIT_HOME_PUBLIC}` nix-home sessionVariables still exist for workspace tooling — this PR just stops mentioning them in plugin docs where they're not load-bearing. Assisted-by: Claude <noreply@anthropic.com>
32b4137 to
6f0ff07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #330. That PR swapped hardcoded
~/git/...references for${GIT_HOME_PUBLIC}/<repo>/.... Reviewer pushback: skill docs and convention rules shouldn't bake any local workspace path into prose at all — describe what to do, not where files live.What changed (10 files)
.claude/rules/worktree-conventions.md: convention table shows relative paths (<repo>/main/,<repo>/{branch-name}/). Operational sync line dropscd, frames as "from the main worktree".git-standards/skills/git-workflow-standards/SKILL.md: layout diagram + table use relative paths. Create/Remove commands use../from the main worktree.git-workflows/skills/sync-main: "find and sync main" describes the worktree role; dropscd.git-workflows/skills/troubleshoot-worktree:git worktree add ../<branch>(relative).github-workflows/skills/rebase-pr: "from the main worktree" framing.github-workflows/skills/refresh-repo: drop the${GIT_HOME}/CLAUDE.mdcitation; drop the${GIT_HOME_PUBLIC}/<repo>/<default>/path-resolution rule in favor ofgit worktree list --porcelainmatching onbranch refs/heads/<default>;--sweepglob description loosened.infra-orchestration/orchestrate-infra: "locate each target repo's main worktree" instead of a path glob.infra-orchestration/sync-inventory: "from the X main worktree" framing; repo list shows names only.infra-orchestration/test-e2e: same.codeql-resolver/README.md: examples annotate the worktree, dropcd.Why this PR exists separately from #330
The user merged #330 quickly after open; the further-cleanup amend (this PR's content) didn't have time to apply pre-merge. Splitting into a follow-up keeps history clean rather than force-pushing already-merged content.
Related
JacobPEvans/ai-assistant-instructions#658applying the same lens${GIT_HOME}/${GIT_HOME_PUBLIC}nix-home sessionVariables stay — this PR just stops referencing them in docs where they're not load-bearingAssisted-by: Claude noreply@anthropic.com