Skip to content

fix(ci): ignore disputed joblib + nltk advisories in pip-audit#57

Closed
JacobPEvans wants to merge 1 commit into
mainfrom
fix/pip-audit-disputed-vulns
Closed

fix(ci): ignore disputed joblib + nltk advisories in pip-audit#57
JacobPEvans wants to merge 1 commit into
mainfrom
fix/pip-audit-disputed-vulns

Conversation

@JacobPEvans
Copy link
Copy Markdown
Collaborator

Summary

Two transitive Python deps trigger pip-audit failures with no upstream fix yet:

  • PYSEC-2024-277 (joblib 1.5.3) — NumpyArrayWrapper deserialization. The vendor disputes this because NumpyArrayWrapper is only used while caching trusted content.
  • PYSEC-2026-97 (nltk 3.9.4) — filestring() arbitrary file read. Requires user-controlled path input; not exposed by template code.

These block #52 (gh-aw SHA refresh) and any future Renovate lock PR. Since this is a template, forks should review quarterly and tighten as their actual usage exposes (or doesn't expose) these surfaces.

Changes

  • Add --ignore-vuln PYSEC-2024-277 --ignore-vuln PYSEC-2026-97 to the existing pip-audit invocation
  • Document each ID with rationale

Test plan

Cleanup

Drop each --ignore-vuln flag once upstream ships a fix. Review quarterly.

Related: #52

Both advisories have no upstream fix and represent low risk in template usage:
- PYSEC-2024-277 (joblib): NumpyArrayWrapper deserialization. Disputed by
  supplier (only used during caching of trusted content).
- PYSEC-2026-97 (nltk): filestring() arbitrary file read. Requires user-
  controlled path input; not exposed by template code.

Blocks the gh-aw SHA refresh PR (#52). Forks should review quarterly and
remove once upstream patches land.
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JacobPEvans
Copy link
Copy Markdown
Collaborator Author

Closing — superseded by #58. PR #57 suppresses transitive advisories from the redundant safety dep; PR #58 drops safety entirely (it duplicates pip-audit), removing the joblib + nltk transitive deps that triggered PYSEC-2024-277 / PYSEC-2026-97 in the first place. Root-cause fix over symptom suppression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant