Skip to content

Classify finding #7 as a false positive - #1637

Draft
mmanela with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-code-quality-findings-7
Draft

Classify finding #7 as a false positive#1637
mmanela with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-code-quality-findings-7

Conversation

Copilot AI commented Jul 8, 2026

Copy link
Copy Markdown

Finding #7 flagged py/ineffectual-statement in a Protocol definition, but the reported code is a valid type-stub pattern rather than dead or effectless logic. This PR records that assessment; no source changes were required.

  • Finding assessment

    • Confirmed the reported statement is the ... placeholder body of Protocol methods in bowtie/_commands.py
    • Determined the finding is a false positive for interface-style method declarations
  • Code changes

    • No production or test code changes
  • Affected pattern

    class Command(Protocol[R]):
        def to_request(self, validate: Callable[..., None]) -> dict[str, Any]:
            ...

Copilot AI changed the title [WIP] Fix code quality finding #7 Classify finding #7 as a false positive Jul 8, 2026
Copilot AI requested a review from mmanela July 8, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants