chore: update slophammer-ts to ^0.3.0 and run checker in CI#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The slophammer-ts devDependency was pinned at ^0.1.2, and CI only ran the DRY gate — never
slophammer-ts checkitself, so the rule config inslophammer.ymlwas effectively decoration.This change bumps the checker to ^0.3.0, migrates the config to the nested shape the checker now requires, and adds the missing
checkinvocation to both CI and the publish workflow.0.3.0 enforces exactly this: a repo with a slophammer config must run the checker in CI that can actually fail.
What Changed
The dependency, the config shape, and the CI wiring moved together.
package.json/package-lock.json:slophammer-ts^0.1.2→^0.3.0, plus a new"slophammer": "slophammer-ts check ."script.slophammer.yml:coverage_threshold→coverage.threshold,complexity_max→complexity.max,mutation_targets→mutation.targets..github/workflows/ci.ymlandpublish.yml: anpm run slophammerstep after the existing dry and mutate steps.Testing
I ran the full gate chain locally against the released 0.3.0 package.
npm run check(format, lint, typecheck, test, coverage, build) — passesnpm run dry— 0 candidatesnpm run mutate(Stryker dry-run) — passesnpm run slophammer— OK: no findings, scope: 12 of 12 production filesRisks
Low. The new CI step can only fail if the checker finds a real regression, which is its purpose; everything passes today.