Replace rewind() with fseek() for error handling#380
Open
manoj23 wants to merge 1 commit into
Open
Conversation
rewind() is equivalent to (void)fseek(fp, 0L, SEEK_SET) and silently discards any seek error. Replace with fseek() and check the return value in readfile.h and fileio.c so that a failed seek propagates to the caller via the existing fail path. Signed-off-by: Georges Savoundararadj <savoundg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Replace rewind() with fseek() for error handling
Summary
rewind()is equivalent to(void)fseek(fp, 0L, SEEK_SET)and silently discards any seek error. This replaces it withfseek()and checks the return value inreadfile.handfileio.cso that a failed seek propagates to the caller via the existingfailpath.Changes
include/flatcc/support/readfile.h: replacerewind(fp)withif (fseek(fp, 0L, SEEK_SET)) goto fail;src/compiler/fileio.c: same changeMotivation
Static analysis (CWE-676) flags
rewind()as a potentially dangerous function because it provides no way to detect errors. Both call sites already have afaillabel with proper cleanup, so wiring in the error check is straightforward.Testing
Built and tested with CMake on Linux (gcc/clang). No behavioral change for the success path; the fail path now correctly triggers on seek errors.