feat: make maven step optional - #118
Merged
Merged
Conversation
hobbyhacker0
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable java-security GitHub Actions workflow to allow running without GitHub Packages/Maven credentials, and attempts to change the default Java version behavior.
Changes:
- Makes GitHub Packages credentials (
USER_NAME,ACCESS_TOKEN,PACKAGE_REPO) optional for callers. - Guards the Maven
settings.xmlgeneration step behind a conditional so it only runs when those secrets are provided. - Changes the default
java_versioninput from11tolatest(this appears incompatible withactions/setup-java).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hobbyhacker0
force-pushed
the
feat/make_maven_step_optional
branch
from
August 18, 2026 10:42
1b1e65e to
3121d06
Compare
sdh100shaun
approved these changes
Aug 18, 2026
ibrahimjassat
approved these changes
Aug 18, 2026
adamjgriffith
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the maven step optional in java-security workflow
Have put this into use on a team repo, working OK
Before submitting (or marking as "ready for review")