Fix spline extrapolation - #81
Merged
toastedcrumpets merged 4 commits intoAug 22, 2026
Merged
Conversation
Previously the high BC value was used, which would give incorrect results unless both BCs had the same value. See dynamomd#80
The difference formula for the first derivative at the left endpoint was incorrect. Instead, use the linear coefficient of the spline polynomial over the first interval, since that is the first derivative at the low endpoint. See dynamomd#80
The formula for the first derivative at the high endpoint was incorrect, having an erroneous factor of 2 on the first term. See dynamomd#80
Extrapolations using the second derivative were missing coefficients of 0.5, resulting in incorrect values. See dynamomd#80
Collaborator
|
LGTM, CI fails but its the constant moving target of the wheel building, so I'm happy to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed several mathematical errors related to spline extrapolation:
Closes #80