Skip to content

Lint benchmarks in CI #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
de-code merged 1 commit into from
Aug 18, 2026
Merged

Lint benchmarks in CI #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,19 +135,19 @@ COPY --from=python-dist-builder /opt/sciencebeam_parser/dist /dist
# lint-flake8
FROM dev AS lint-flake8

RUN python -m flake8 sciencebeam_parser tests
RUN python -m flake8 sciencebeam_parser tests benchmarks


# lint-pylint
FROM dev AS lint-pylint

RUN python -m pylint sciencebeam_parser tests
RUN python -m pylint sciencebeam_parser tests benchmarks


# lint-mypy
FROM dev AS lint-mypy

RUN python -m mypy --ignore-missing-imports sciencebeam_parser tests
RUN python -m mypy --ignore-missing-imports sciencebeam_parser tests benchmarks


# pytest
Expand Down
4 changes: 3 additions & 1 deletion benchmarks/tests/report_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@ def test_each_corpus_has_collapsible_section(self):

class TestUnequalDocsNote:
def test_silent_when_every_run_covered_the_same_documents(self):
# pylint: disable=use-implicit-booleaness-not-comparison
# the empty list is the contract; `not ...` would also accept None
assert _unequal_docs_note([("grobid", 10), ("local", 10)]) == []

def test_calls_out_a_difference_with_the_counts(self):
Expand Down Expand Up @@ -351,5 +353,5 @@ def test_overall_ignores_a_corpus_only_one_run_scored(self):
assert "Overall (10 docs across 1 corpora)" in report
assert "Excludes b, which not every run scored" in report
# The unequal-columns warning belongs to b's own section, not the overall row.
overall = report.split("<details>")[0]
overall = report.split("<details>", maxsplit=1)[0]
assert "Unequal document sets" not in overall
Loading