Skip to content

[25442] Make skip-ci label report required statuses as pass#323

Merged
MiguelCompany merged 3 commits into
masterfrom
ci/25442
Jun 23, 2026
Merged

[25442] Make skip-ci label report required statuses as pass#323
MiguelCompany merged 3 commits into
masterfrom
ci/25442

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Jun 19, 2026 •
edited by cferreiragonz
Loading

Copy link
Copy Markdown
Member

Description

Move conditionals in the CI from jobs to steps, so the options in matrix are always considered, and thus all the corresponding statuses are shown as passed when the skip-ci label is present.

@Mergifyio backport 2.3.x 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@MiguelCompany
Refs #25442. Make skip-ci label report required statuses as pass.
b009e58 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.4.0 milestone Jun 19, 2026
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jun 22, 2026
@MiguelCompany
MiguelCompany requested review from richiprosima and removed request for richiprosima June 22, 2026 10:23
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label and removed ci-pending skip-ci Automatically pass CI labels Jun 22, 2026
@MiguelCompany
MiguelCompany requested review from richiprosima and removed request for richiprosima June 22, 2026 10:25
@MiguelCompany MiguelCompany added skip-ci Automatically pass CI and removed ci-pending no-test Skip CI tests if PR marked with this label labels Jun 22, 2026
@MiguelCompany
MiguelCompany requested review from richiprosima and removed request for richiprosima June 22, 2026 10:43
@MiguelCompany MiguelCompany removed ci-pending skip-ci Automatically pass CI labels Jun 22, 2026
@MiguelCompany
MiguelCompany requested review from richiprosima and removed request for richiprosima June 22, 2026 10:44
cferreiragonz
cferreiragonz requested changes Jun 23, 2026
View reviewed changes
Comment thread .github/workflows/reusable-ci.yml
Comment thread .github/workflows/reusable-ci.yml Outdated
@MiguelCompany
Refs #25442. Fix condition in Archive Test Results.
4d57e17 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #25442. Fix condition for add-label.
99c71aa 
Also improve readability.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added skip-ci Automatically pass CI and removed ci-pending labels Jun 23, 2026
@MiguelCompany
MiguelCompany requested review from cferreiragonz and removed request for cferreiragonz June 23, 2026 10:14
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Jun 23, 2026
@MiguelCompany
MiguelCompany merged commit a6c31c0 into master Jun 23, 2026
24 checks passed
@MiguelCompany
MiguelCompany deleted the ci/25442 branch June 23, 2026 10:21
@MiguelCompany

MiguelCompany commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport 2.3.x 2.2.x 1.0.x

@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

backport 2.3.x 2.2.x 1.0.x

✅ Backports have been created

Details

This was referenced Jun 23, 2026
Merged
Merged
Merged
MiguelCompany added a commit that referenced this pull request Jun 23, 2026
@mergify @MiguelCompany
Make skip-ci label report required statuses as pass (#323) (#326)
d48bbd5 
* Refs #25442. Make `skip-ci` label report required statuses as pass.



* Refs #25442. Fix condition in Archive Test Results.



* Refs #25442. Fix condition for add-label.
Also improve readability.



---------


(cherry picked from commit a6c31c0)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 23, 2026
@mergify @MiguelCompany
Make skip-ci label report required statuses as pass (#323) (#325)
5c60627 
* Refs #25442. Make `skip-ci` label report required statuses as pass.



* Refs #25442. Fix condition in Archive Test Results.



* Refs #25442. Fix condition for add-label.
Also improve readability.



---------


(cherry picked from commit a6c31c0)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 23, 2026
@mergify @MiguelCompany
Make skip-ci label report required statuses as pass (#323) (#324)
899f8e9 
* Refs #25442. Make `skip-ci` label report required statuses as pass.



* Refs #25442. Fix condition in Archive Test Results.



* Refs #25442. Fix condition for add-label.
Also improve readability.



---------


(cherry picked from commit a6c31c0)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees

No one assigned

Labels

ci-pending no-test Skip CI tests if PR marked with this label

Projects

None yet

Milestone

v2.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @cferreiragonz