Skip to content

[24566] Improve checks for sequence lengths#327

Merged
MiguelCompany merged 5 commits into
masterfrom
bugfix/24566
Jul 2, 2026
Merged

[24566] Improve checks for sequence lengths#327
MiguelCompany merged 5 commits into
masterfrom
bugfix/24566

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Jul 2, 2026

Copy link
Copy Markdown
Member

Description

This improves the check_bad_length_deserialization tests to include a DHEADER when required, adds a missing check on sequence length, and adds checks when deserializing a DHEADER.

@Mergifyio backport 2.3.x 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.4.0 milestone Jul 2, 2026
@MiguelCompany
MiguelCompany requested a review from richiware July 2, 2026 08:10
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
MiguelCompany requested review from richiware and removed request for richiware July 2, 2026 08:14
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
MiguelCompany requested review from richiware and removed request for richiware July 2, 2026 08:37
@MiguelCompany
MiguelCompany merged commit db7e730 into master Jul 2, 2026
17 checks passed
@MiguelCompany
MiguelCompany deleted the bugfix/24566 branch July 2, 2026 09:20
@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@MiguelCompany

Copy link
Copy Markdown
Member Author

@Mergifyio backport 2.3.x 2.2.x

@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown

backport 2.3.x 2.2.x

✅ Backports have been created

Details

MiguelCompany added a commit that referenced this pull request Jul 2, 2026
* Refs #24566. Improve tests.



* Refs #24566. Check sequence length in XCDR2 path.



* Refs #24566. Check dheader and improve error state.



* Refs #24566. Remove unused variables.



* Refs #24566. Uncrustify.



---------


(cherry picked from commit db7e730)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jul 2, 2026
* Refs #24566. Improve tests.



* Refs #24566. Check sequence length in XCDR2 path.



* Refs #24566. Check dheader and improve error state.



* Refs #24566. Remove unused variables.



* Refs #24566. Uncrustify.



---------


(cherry picked from commit db7e730)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants