Repository navigation
Support string values as well as cross-references for properties - #60
Merged
elichad merged 3 commits intoOct 7, 2026
Conversation
elichad
reviewed
Oct 7, 2026
|
|
||
| # Add triple <new profile URI> schema:author <new author URI> | ||
| if p == SCHEMA.author and isinstance(o, Literal): | ||
| new_o = map_sameas_uri(o, "author") |
Contributor
There was a problem hiding this comment.
does this mean that if the same author string (like "Fairscape Team") appears in multiple profiles, they will be linked together in the internal knowledge graph?
Contributor
Author
There was a problem hiding this comment.
Yes. If this is not desired then maybe a urn could be used?
Contributor
There was a problem hiding this comment.
I think it's actually quite nice - but we should be aware that this might mistakenly connect unrelated authors who share the same name. For now I think the convenience factor outweighs the risk, and we encourage people to include their ORCIDs anyway which would mitigate this.
elichad
approved these changes
Oct 7, 2026
AnnieZQH
deleted the
57-support-string-values-as-well-as-cross-references-for-properties
branch
October 7, 2026 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #57
Changes:
Screenshots:
nameas label, and fallback tovalue(see screenshot) or@idif it doesn't existurl, and fallback to@idif doesn't exist