Skip to content

Run validation on submitted profiles as part of ci checks - #64

Merged
AnnieZQH merged 16 commits into
developmentfrom
55-run-validation-on-submitted-profiles-as-part-of-ci-checks
Oct 15, 2026
Merged

Run validation on submitted profiles as part of ci checks#64
AnnieZQH merged 16 commits into
developmentfrom
55-run-validation-on-submitted-profiles-as-part-of-ci-checks

Conversation

@AnnieZQH

@AnnieZQH AnnieZQH commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #55

Changes:

  • Added a Python script to validate the profile urls
  • Updated the check GitHub Action to validate the new profile added in a PR
  • Updated requirements
  • Refactored upload_profiles.py and moved reusable code into utils

@AnnieZQH AnnieZQH linked an issue Oct 9, 2026 that may be closed by this pull request
Run validation on submitted profiles as part of CI checks #55
Closed
elichad
elichad requested changes Oct 13, 2026
View reviewed changes

@elichad elichad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks nice, I think it will work as-is but have a few suggested improvements

Comment thread scripts/utils.py
Comment thread scripts/validate_profiles.py Outdated
Comment thread scripts/validate_profiles.py Outdated
Comment thread scripts/validate_profiles.py Outdated
Comment thread scripts/validate_profiles.py
Comment thread scripts/validate_profiles.py Outdated
@AnnieZQH
AnnieZQH force-pushed the 55-run-validation-on-submitted-profiles-as-part-of-ci-checks branch from 30a380e to 506c71c Compare October 13, 2026 13:03
@AnnieZQH

AnnieZQH commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Latest run triggered by PR: https://github.com/eScienceLab/RO-Crate-Profile-Portal/actions/runs/38418385473/job/115368813403?pr=64

Latest run triggered by workflow_dispatch: https://github.com/eScienceLab/RO-Crate-Profile-Portal/actions/runs/38417165155/job/115364566457

Last task before this PR is ready for review/merge:

  • Populate VALIDATION_EXCEPTIONS

@AnnieZQH
AnnieZQH requested a review from elichad October 14, 2026 13:09
elichad
elichad approved these changes Oct 15, 2026
View reviewed changes

@elichad elichad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good; I have looked through the failures on the pull_request check and think we can ignore/override them. You could add them to VALIDATION_EXCEPTIONS or just merge, I don't mind.
Many of the workflow_dispatch errors are now WIP fixes on the various profile repos, so I'm inclined not to go through them again until some of those fixes are done. We can revisit this again later now that we have the tooling to do so.

@AnnieZQH
AnnieZQH marked this pull request as ready for review October 15, 2026 13:25
@AnnieZQH
AnnieZQH merged commit 15652f0 into development Oct 15, 2026
1 check passed
@AnnieZQH
AnnieZQH deleted the 55-run-validation-on-submitted-profiles-as-part-of-ci-checks branch October 15, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elichad elichad elichad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run validation on submitted profiles as part of CI checks

2 participants

@AnnieZQH @elichad