Skip to content

feat(mixins): add mixins#279

Open
mnboos wants to merge 10 commits into
eadwinCode:masterfrom
mnboos:master
Open

feat(mixins): add mixins#279
mnboos wants to merge 10 commits into
eadwinCode:masterfrom
mnboos:master

Conversation

@mnboos

@mnboos mnboos commented Jun 24, 2025

Copy link
Copy Markdown

This is the PR with the mixin-functionality as shown in #278

@mnboos mnboos mentioned this pull request Jun 24, 2025
@eadwinCode

Copy link
Copy Markdown
Owner

@mnboos This is amazing, well done. But is there a written test for this feature?

@mnboos

mnboos commented Jun 29, 2025

Copy link
Copy Markdown
Author

Thank you!

No,.not yet. I thought I will do this, if you basically liked it. Which seems to be the case. So, shall I write tests and docs for it? I guess I shall. 😁

@mnboos

mnboos commented Jul 1, 2025

Copy link
Copy Markdown
Author

I added tests and docs.

Coverage:

___________________________________ coverage: platform linux, python 3.12.8-final-0 ____________________________________

Name                                               Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------
...
ninja_extra/mixins/__init__.py                       174      0   100%
...
--------------------------------------------------------------------------------
TOTAL                                               2990     56    98%
========================================== 454 passed, 87 warnings in 12.26s ===========================================

@codecov-commenter

codecov-commenter commented Jul 3, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.15%. Comparing base (6a592c1) to head (64cd298).
⚠️ Report is 167 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   98.01%   98.15%   +0.14%     
==========================================
  Files          68       69       +1     
  Lines        2770     2987     +217     
==========================================
+ Hits         2715     2932     +217     
  Misses         55       55              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mnboos

mnboos commented Aug 13, 2025

Copy link
Copy Markdown
Author

Hi @eadwinCode

Would you like additional information or support in order to merge this PR?

@eadwinCode

eadwinCode commented Aug 15, 2025

Copy link
Copy Markdown
Owner

@mnboos
Thanks again for working on this feature. I haven’t yet had the time to fully review some of the features you introduced on the mixin approach, for example, ordering.
My goal is that the mixin and model_config approaches for ModelController to works the same way, without limitations between them. Its left for the people to choose what works for them, mixin or model_config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants