Skip to content

Refactor clone_field method implementation #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Izcarmt95 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor clone_field method implementation #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
154ed1a
Refactor clone_field method implementation
Izcarmt95 Jul 14, 2026
78ae3b0
Rename 'category' to 'category_id' in schema test
Izcarmt95 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ninja_schema/orm/model_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,11 @@ def __init__(

@classmethod
def clone_field(cls, field: FieldInfo, **kwargs: Any) -> FieldInfo:
field_dict = dict(field.__repr_args__())
field_dict.update(**kwargs)
new_field = FieldInfo(**field_dict) # type: ignore
new_field = field._copy()
for key, value in kwargs.items():
setattr(new_field, key, value)
new_field.rebuild_annotation()

return new_field

def model_fields(self) -> Iterator[Field]:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_v2_pydantic/test_model_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ class Config:
"description": "",
"title": "Title",
},
"category": {
"category_id": {
"anyOf": [{"type": "integer"}, {"type": "null"}],
"default": None,
"description": "",
Expand Down
Loading