Keep affected running after merged PRs when Publish or Deploy reads it - #103
Merged
Conversation
skipMergedPrPush was skipping the Verify-shaped affected job, so Graph Publish/Deploy fromJson an empty output. Mirror the tag-push treatment: affected stays up and emits ["all"], and Graph Verify carries its own gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipMergedPrPushwas skipping the Verify-shapedaffectedjob, so Graph Publish/Deploy started with an emptyneeds.affected.outputs.modulesandfromJson("")failed the workflow template.affected, that job stays up on a merged-PR push and emits["all"]. Graph Verify jobs carry their ownverify-gateclause instead of inheriting the skip throughaffected.Test plan
sbt "core/testFull; docs/testFull"sbt scalafmtCheckAllmainon a repo with Graph docker +skipMergedPrPush(optimize-frequency is the failing fixture). Expectaffectedgreen with["all"], Verify skipped, docker/deploy actually running, noJsonReaderException.