Skip to content

⚡ Configure v0.1.2 retrieval fanout budgets#53

Merged
ebigunso merged 4 commits into
mainfrom
copilot/v0-1-2-closeout-impl
Jun 13, 2026
Merged

⚡ Configure v0.1.2 retrieval fanout budgets#53
ebigunso merged 4 commits into
mainfrom
copilot/v0-1-2-closeout-impl

Conversation

@ebigunso

Copy link
Copy Markdown
Owner

Summary

  • externalize v0.1.2 retrieval fanout budgets into settings while preserving previous defaults
  • wire configured budgets into retrieval selectivity policy without changing public API shape
  • add facade-level guardrail integration tests for stats reopen, lifecycle exclusion after restart, and selectivity/fanout override behavior
  • bump crate version to 0.1.2

Validation

  • cargo fmt --check && cargo check && cargo test
  • result: passed
  • tests: 299 unit passed, 2 ignored; integration tests passed (1 initialization, 3 v0.1.2 guardrails, 2 public facade); doc tests passed

Notes

Copilot AI review requested due to automatic review settings June 13, 2026 09:33
@ebigunso ebigunso self-assigned this Jun 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR externalizes the v0.1.2 retrieval selectivity “fanout” budgets into configuration (while keeping the same defaults), wires those configured budgets into the internal retrieval selectivity policy, and adds integration tests to ensure retrieval guardrails behave correctly across facade reopen/restart scenarios. It also bumps the crate version to 0.1.2.

Changes:

  • Add nested retrieval.fanout.* settings (config + env var support) with validation and preserved defaults.
  • Apply configured fanout budgets when building the RetrievalSelectivityPolicy.
  • Add v0.1.2 integration tests covering stats persistence, lifecycle exclusions after restart, and fanout override behavior; bump crate version.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/v0_1_2_retrieval_guardrails_tests.rs Adds facade-level integration tests validating v0.1.2 guardrails and fanout overrides across reopen/restart.
tests/test_utils.rs Adds a persistent-store test setup helper and optional retrieval fanout overrides for integration tests.
src/lib.rs Plumbs configured fanout budgets from Settings into the retrieval selectivity policy constructor.
src/internal/repositories/retrieval_selectivity.rs Adds support for per-(relation, object_type) fanout budget overrides and corresponding unit tests.
src/config/settings/app_settings.rs Introduces nested retrieval fanout settings, env var parsing, validation, and default budgets.
Cargo.toml Bumps crate version to 0.1.2.
Cargo.lock Updates lockfile version entry to 0.1.2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/internal/repositories/retrieval_selectivity.rs
Comment thread src/config/settings/app_settings.rs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Comment thread src/internal/repositories/retrieval_selectivity.rs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Comment thread src/config/settings/app_settings.rs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.

@ebigunso ebigunso changed the title feat: configure v0.1.2 retrieval fanout budgets ⚡ Configure v0.1.2 retrieval fanout budgets Jun 13, 2026
@ebigunso ebigunso changed the title ⚡ Configure v0.1.2 retrieval fanout budgets ⚡ Configure v0.1.2 retrieval fanout budgets Jun 13, 2026
@ebigunso ebigunso merged commit b52754e into main Jun 13, 2026
7 checks passed
@ebigunso ebigunso deleted the copilot/v0-1-2-closeout-impl branch June 13, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants