⚡ Configure v0.1.2 retrieval fanout budgets#53
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR externalizes the v0.1.2 retrieval selectivity “fanout” budgets into configuration (while keeping the same defaults), wires those configured budgets into the internal retrieval selectivity policy, and adds integration tests to ensure retrieval guardrails behave correctly across facade reopen/restart scenarios. It also bumps the crate version to 0.1.2.
Changes:
- Add nested
retrieval.fanout.*settings (config + env var support) with validation and preserved defaults. - Apply configured fanout budgets when building the
RetrievalSelectivityPolicy. - Add v0.1.2 integration tests covering stats persistence, lifecycle exclusions after restart, and fanout override behavior; bump crate version.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/v0_1_2_retrieval_guardrails_tests.rs | Adds facade-level integration tests validating v0.1.2 guardrails and fanout overrides across reopen/restart. |
| tests/test_utils.rs | Adds a persistent-store test setup helper and optional retrieval fanout overrides for integration tests. |
| src/lib.rs | Plumbs configured fanout budgets from Settings into the retrieval selectivity policy constructor. |
| src/internal/repositories/retrieval_selectivity.rs | Adds support for per-(relation, object_type) fanout budget overrides and corresponding unit tests. |
| src/config/settings/app_settings.rs | Introduces nested retrieval fanout settings, env var parsing, validation, and default budgets. |
| Cargo.toml | Bumps crate version to 0.1.2. |
| Cargo.lock | Updates lockfile version entry to 0.1.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --check && cargo check && cargo testNotes