fix: GitHub theme and catalog view padding gaps#91
Open
johnnyhuy wants to merge 3 commits into
Open
Conversation
- Add MISE_PYTHON_GITHUB_ATTESTATIONS=false to Dockerfile (both build and run stages) to bypass mise Python 3.10.12 attestation failures in mise 2026.5.16+ - Copy .yarn/plugins/ and backstage.json before yarn install in build stage - the Backstage Yarn plugin requires these to resolve backstage:^ version ranges - Remove yarn tsc from Dockerfile - type checking is already covered by backstage-cli repo lint in CI - Copy .yarn/plugins/ and backstage.json before yarn workspaces focus in run stage for the same reason - Run mise install locally to rebuild native modules (better-sqlite3, isolated-vm, cpu-features) for Node 22 ABI
- Fix GitHub Light/Dark themes missing text colors and component overrides
- Import styles.css into GitHub theme package
- Add MuiGrid, MuiTypography, MuiCard overrides to GitHub themes
- Remove negative marginBottom from catalog Grid items
- Add consistent spacing={2} to all catalog Grid containers
- Increase default theme MuiGrid padding from .5rem to 1rem
- Fix missing item prop on nested Grid in apiPage
- Remove MuiGrid overrides from both default and GitHub themes The overrides broke MUI's spacing prop by zeroing out item padding - Add global CSS fix for Backstage's v5-MuiGrid class name prefix Backstage's UnifiedThemeProvider adds 'v5-' prefix to MUI classes, but Grid's internal CSS still targets .MuiGrid-item selectors. This mismatch caused all Grid items to have 0 padding, making cards touch each other across all pages. - Import grid-fix.css in index.tsx so it applies globally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marginBottom={-1}from catalog Grid items that caused cards to touchspacing={2}to all catalog Grid containers for proper gapsv5-MuiGridclass name prefix mismatchUnifiedThemeProviderconfigures MUI'sClassNameGeneratorto add av5-prefix.MuiGrid-itemselectorspackages/app/src/styles/grid-fix.csswith selectors targeting the prefixed classesConsequences
spacingprop correctlyTesting
mise run lintpassed (type-check + lint across all packages)