feat: add --theia-api-port and --theia-api-token flags - #8
Draft
sdirix wants to merge 1 commit into
Draft
Conversation
--theia-api-port publishes a container port on host loopback and enables Theia's separate-port external API on it by injecting the externalApi.* preferences. This applies to the --background auto-launch and to the theia/theia-next re-attach verbs. --theia-api-token sets the external API token. Without it no token preference is set. The port is only published for tools that launch a Theia IDE, using the same post_start.open_ide signal as the auto-launch. For other tools nothing would listen on the port, so the flag is ignored with a warning. The token reaches the IDE process via argv and stays visible in ps, which is acceptable for the loopback dev flow this targets. It is redacted from the launch log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--theia-api-port publishes a container port on host loopback and enables Theia's separate-port external API on it by injecting the externalApi.* preferences. This applies to the --background auto-launch and to the theia/theia-next re-attach verbs. --theia-api-token sets the external API token. Without it no token preference is set.
The port is only published for tools that launch a Theia IDE, using the same post_start.open_ide signal as the auto-launch. For other tools nothing would listen on the port, so the flag is ignored with a warning.
The token reaches the IDE process via argv and stays visible in ps, which is acceptable for the loopback dev flow this targets. It is redacted from the launch log.