Skip to content

Make header logo alt text configurable via branding config - #1349

Merged
jaredgalanis merged 1 commit into
eclipse-pass:mainfrom
uvalib:1260-configurable-logo-alt-text
Aug 19, 2026
Merged

Make header logo alt text configurable via branding config#1349
jaredgalanis merged 1 commit into
eclipse-pass:mainfrom
uvalib:1260-configurable-logo-alt-text

Conversation

@dougchestnut

Copy link
Copy Markdown
Contributor

Summary

Lets each deployment set the header logo’s accessible name in branding config, instead of hard-coding alt="Logo".

  • Adds optional branding.logoAlt next to branding.logo.
  • Header <img id="brand-logo"> uses that value.
  • If logoAlt is missing, alt stays "Logo" so existing config.json files keep working.
  • Dev, Mirage, and sample configs set logoAlt to "Eclipse Foundation" for the bundled Eclipse mark.

Fixes eclipse-pass/main#1260

How to test

  1. Run pass-ui locally (Mirage / Vite config.json is enough).
  2. Inspect #brand-logoalt should be Eclipse Foundation.
  3. Remove logoAlt from the served config, reload — alt should be Logo.
  4. Set logoAlt to another string, reload — the attribute should match.
  5. Confirm the logo still links to branding.homepage.

@sonarqubecloud

Copy link
Copy Markdown

@markpatton

Copy link
Copy Markdown
Contributor

This makes sense to me and it worked locally. I will ask someone with a better sense of pass-ui to do a review.

@jaredgalanis jaredgalanis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jaredgalanis
jaredgalanis merged commit 137e988 into eclipse-pass:main Aug 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make header logo alt text configurable via branding config

3 participants