Fix heading hierarchy and restore proper heading levels (#1261) - #1350
Open
dougchestnut wants to merge 1 commit into
Open
Fix heading hierarchy and restore proper heading levels (#1261)#1350dougchestnut wants to merge 1 commit into
dougchestnut wants to merge 1 commit into
Conversation
…#1261) Updates headings across templates and components to follow semantic hierarchy: - Update top-level page titles to h1 and adjust section/subsection levels (h2, h3). - Introduce helper typography classes in app.css (.brand-header-title, .page-heading, .section-title, .subsection-title, .block-title). - Update tests matching new heading selectors. Fixes eclipse-pass/main#1261 Signed-off-by: Doug Chestnut <dougchestnut@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses accessibility and semantic heading hierarchy issues identified in eclipse-pass/main#1261.
Changes
<h1>across templates (dashboard,not-found-error,workflow-wrapper).<span>(brand-header-title).<h2>,<h3>) throughout workflow and detail pages (grants/detail,submissions/detail,workflow-grants,workflow-repositories,workflow-review,policy-card).app.css(.brand-header-title,.page-heading,.section-title,.subsection-title,.block-title) to decouple semantic structure from visual presentation and preserve visual styling.workflow-grants-test.ts).Issue
Fixes eclipse-pass/main#1261