feat: change mandatory 'fulfils' to optional by RolandJentschETAS · Pull Request #669 · eclipse-score/docs-as-code

RolandJentschETAS · 2026-07-28T08:53:04Z

📌 Description

Change link from arch to req to optional, as process defines it in this way.

🚨 Impact Analysis

This change does not violate any tool requirements and is covered by existing tool requirements
This change does not violate any design decisions
Otherwise I have created a ticket for new tool qualification

✅ Checklist

Added/updated documentation for new or changed features
Added/updated tests to cover the changes
Followed project coding standards and guidelines

github-actions · 2026-07-28T08:53:45Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 364daac6-4743-451d-a09d-63e40380b952
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=ppc64le-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=riscv64-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=s390x-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=x86_64-unknown-linux-musl. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 7.803s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

MaximilianSoerenPollak · 2026-07-28T09:11:28Z

📌 Description

Change link from arch to req to optional, as process defines it in this way.

Do you have a link to this?

RolandJentschETAS · 2026-07-28T10:03:05Z

📌 Description

Change link from arch to req to optional, as process defines it in this way.

Do you have a link to this?

Sure. See https://eclipse-score.github.io/process_description/main/general_concepts/score_building_blocks_concept.html. The lines are blue, what means optional according to the legend. See also https://eclipse-score.github.io/process_description/main/process_areas/architecture_design/guidance/architecture_process_reqs.html#gd_req__arch_attr_fulfils. (should be == optional)

github-actions · 2026-07-28T10:03:34Z

The created documentation from the pull request is available at: docu-html

AlexanderLanin

The proposed optionality conflicts with the current tool requirements. Please either retain these mandatory links or update and re-qualify the affected requirements in docs/internals/requirements/requirements.rst before this metamodel change.

generated by Codex running GPT 5.6 Terra

AlexanderLanin · 2026-07-28T18:33:01Z

      belongs_to: feat # make it mandatory for evaluation
+    optional_links:
+      # req-Id: tool_req__docs_arch_link_fulfils, tool_req__docs_arch_link_fulfils_aou
+      fulfils: feat_req, aou_req


tool_req__docs_arch_link_fulfils is titled “Mandatory Architecture Attribute: fulfils” and is marked implemented. tool_req__docs_arch_link_fulfils_aou also requires static views to link to an AoU through fulfils. Making this optional permits a feat_arc_sta without any requirement/AoU trace. The same issue applies to the corresponding comp_arc_sta change below.

Please keep fulfils mandatory, or update the tool requirements and their qualification/status as part of this PR.

generated by Codex running GPT 5.6 Terra

Concrete remediation proposal:

Keep the existing ID tool_req__docs_arch_link_fulfils, but bump its version from 2 to 3 and update its title/text to reflect the corrected process semantics, for example:

Title: “Architecture fulfils linkage rules”

Text: “Docs-as-Code shall permit fulfils to be omitted for feat_arc_sta and comp_arc_sta. When fulfils is present, Docs-as-Code shall restrict its target to the source/target combinations in the table below.”
The existing allowed-combinations table can remain.

Update tool_req__docs_arch_link_fulfils_aou as a new version as well: replace “static views link to” with wording that permits, rather than requires, fulfils links to aou_req.

Keep the metamodel requirement references, now referring to the revised requirement versions, and add tests for an unlinked static view (accepted) and an invalid fulfils target (rejected).

If non-QM architecture must still trace to a same-safety requirement, retain that separately as a conditional graph check; making fulfils optional must not bypass it.

A version bump preserves the requirement ID and its traceability history while making the changed semantics explicit.

generated by Codex running GPT 5.6 Terra

Thanks for the detailed proposal. The tool requirements have been updated to make the optional semantics explicit rather than keeping fulfils mandatory:

tool_req__docs_arch_link_fulfils reworded and bumped to version 3 (title "Architecture fulfils linkage rules"; text now: "allow or enforce where necessary that linking via the fulfils attribute follows the defined rules"), allowed-combinations table retained.

tool_req__docs_arch_link_fulfils_aou bumped to version 3 and reworded to permit (not require) a fulfils link to aou_req. This aligns with the base process requirement gd_req__arch_attr_fulfils, which is optional in the process repo.

Added tests: an unlinked static view is accepted, and an invalid fulfils target is still rejected (feat_arc_sta__fulfils__optional / feat_arc_sta__fulfils__bad_target in test_options_options.rst).

Addressed in c07e9cf.

MaximilianSoerenPollak · 2026-07-29T09:42:56Z

  :parent_covered: YES

-  Docs-as-Code shall enforce that linking via the ``fulfils`` attribute follows defined rules.
+  Docs-as-Code shall permit the ``fulfils`` attribute to be omitted for feat_arc_sta and


I would like the wording as follows better:
Docs-as-Code shall allow or enforce where necessary that linking via the ``fulfils`` attribute follows the defined rules.

Then you avoid that whole other thingy no?

Applied your suggested wording. Addressed in c07e9cf.

MaximilianSoerenPollak · 2026-07-29T09:43:39Z

  Architectural static views (feat_arc_sta, comp_arc_sta)
-  link to Assumptions of Use (aou_req) via the ``fulfils`` attribute.
+  may link to Assumptions of Use (aou_req) via the ``fulfils`` attribute.
+  When such a link is present, Docs-as-Code shall restrict its target to aou_req.


The sentence above already includes this stipulation

Suggested change

When such a link is present, Docs-as-Code shall restrict its target to aou_req.

Done — removed the redundant sentence; the reworded sentence above now covers it. Addressed in c07e9cf.

- Reword tool_req__docs_arch_link_fulfils per review (allow/enforce wording) - Mark all architecture fulfils links as optional in metamodel - Add tests for unlinked static view (accepted) and invalid fulfils target (rejected)

change mandatory to optional links

5f47fe6

RolandJentschETAS requested review from AlexanderLanin, MaximilianSoerenPollak, dcalavrezo-qorix and nradakovic as code owners July 28, 2026 08:53

github-project-automation Bot added this to INF - Infrastructure Community Jul 28, 2026

Merge branch 'main' into improvement_optional_arc_links

31e69ba

Merge branch 'main' into improvement_optional_arc_links

56d2172

masc2023 previously approved these changes Jul 28, 2026

View reviewed changes

AlexanderLanin requested changes Jul 28, 2026

View reviewed changes

AlexanderLanin reviewed Jul 28, 2026

View reviewed changes

fix review findings

ce38c53

RolandJentschETAS dismissed masc2023’s stale review via ce38c53 July 29, 2026 05:36

extent table with link type

8590090

MaximilianSoerenPollak reviewed Jul 29, 2026

View reviewed changes

AlexanderLanin approved these changes Jul 30, 2026

View reviewed changes

AlexanderLanin changed the title ~~change mandatory to optional links~~ feat: change mandatory 'fulfils' to optional Jul 30, 2026

RolandJentschETAS merged commit ace3f0a into eclipse-score:main Jul 30, 2026
12 of 14 checks passed

RolandJentschETAS deleted the improvement_optional_arc_links branch July 30, 2026 06:33

github-project-automation Bot moved this to Done in INF - Infrastructure Community Jul 30, 2026

Uh oh!

Conversation

RolandJentschETAS commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Description

🚨 Impact Analysis

✅ Checklist

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

MaximilianSoerenPollak commented Jul 28, 2026

📌 Description

Uh oh!

RolandJentschETAS commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Description

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

AlexanderLanin left a comment

Choose a reason for hiding this comment

Uh oh!

AlexanderLanin Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

AlexanderLanin Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RolandJentschETAS Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

MaximilianSoerenPollak Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

RolandJentschETAS Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

MaximilianSoerenPollak Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

RolandJentschETAS Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RolandJentschETAS commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

RolandJentschETAS commented Jul 28, 2026 •

edited

Loading

AlexanderLanin Jul 28, 2026 •

edited

Loading