Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,20 @@

jobs:
cpp:
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@ea19fcae9aeeb4ac678b750c6c197eaf75414f39 # v0.0.0
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 # v0.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 # v0.0.0
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0

Think the comment with the version doesn't make sense to keep. Same thing with the on line 36

with:
bazel-target: "//score/..."
bazel-config: "x86_64-linux"
extra-bazel-flags: "--test_output=errors --nocache_test_results --lockfile_mode=error --test_lang_filters=-rust,-miri"
artifact-name-suffix: "_cpp"
retention-days: 10
min-coverage: 76
rust:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
uses: eclipse-score/cicd-workflows/.github/workflows/rust-coverage.yml@ea19fcae9aeeb4ac678b750c6c197eaf75414f39 # v0.0.0
uses: eclipse-score/cicd-workflows/.github/workflows/rust-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 # v0.0.0
with:
bazel-test-targets: "//score/..."
bazel-test-config-flags: "--config=x86_64-linux --config=ferrocene-coverage --lockfile_mode=error --test_lang_filters=-cc,-miri"
bazel-test-args: "--test_output=errors --nocache_test_results --build_tag_filters=-miri,-loom --test_tag_filters=-miri,-loom"
coverage-target: "//:rust_coverage"
coverage-artifact-name: "rust-coverage-html"
min-coverage: 93

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
Loading