fix(bazel): 🔧 add cargo_lockfile and lockfile definitions - #69
Open
ian-harmon-traton wants to merge 1 commit into
Open
fix(bazel): 🔧 add cargo_lockfile and lockfile definitions#69ian-harmon-traton wants to merge 1 commit into
ian-harmon-traton wants to merge 1 commit into
Conversation
…specs call newer versions of rules_rust compatibility (since 0.71.1 or 0.71.0) require lock files since repinning across module boundaries is not allowed
|
The created documentation from the pull request is available at: docu-html |
ian-harmon-traton
changed the title
Contributor
|
You need to sign eclipse ECA so we can process with PR |
Contributor
Author
Submitted |
There was a problem hiding this comment.
Pull request overview
Adds reproducible Rust dependency resolution for Bazel’s crate universe.
Changes:
- Configures both required lockfiles.
- Adds generated Cargo and Bazel crate lockfiles.
- Refreshes Bzlmod metadata.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
MODULE.bazel |
References both lockfiles. |
Cargo.lock |
Pins Cargo dependencies. |
Cargo.Bazel.lock |
Pins generated Bazel crate metadata. |
MODULE.bazel.lock |
Refreshes Bzlmod extension state. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the crate.from_specs call in MODULE.bazel, added a
cargo_lockfile = ...andlockfile = ..., and ran the regenerating command for both files.Why
Newer versions of rules_rust compatibility (since 0.71.1 or 0.71.0) require lock files defined in the cargo.from_specs or cargo.from_cargo since repinning across module boundaries is not allowed
Where
Lines 442 & 445 in MODULE.bazel
Cargo.Bazel.lock
Cargo.Lock