Stopped the disclosure check failing on the guide that documents it - #292
Merged
fdesbiens merged 1 commit intoOct 1, 2026
Merged
Conversation
repo_checks has been red on dev since the contribution guide landed. The guide explains the disclosure convention, so it spells the accepted text and discusses AI assistance in prose, and the near-miss rule flags any line mentioning AI assistance that is not the fixed text character for character. Documenting the rule was therefore a violation of it. The guide is now excluded from the scan, for the same reason this script already excludes itself: it has to spell the text in order to explain it. GUIX carried the same defect and took the same fix. Verified that the check still catches what it is for: a second disclosure line in a source file still fails it, and the tree passes without one. Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repo_checkshas been red ondevsince the contribution guide landed. The guide explains the disclosure convention, so it spells the accepted text and discusses AI assistance in prose, and the near-miss rule flags any line mentioning AI assistance that is not the fixed text character for character. Documenting the rule was therefore a violation of it.The guide is now excluded from the scan, for the same reason this script already excludes itself: it has to spell the text in order to explain it.
GUIX carried the same defect and took the same fix in eclipse-threadx/guix#210.
Verified that the check still catches what it is for: a second disclosure line in a source file still fails it, and the tree passes without one.