#6238 Improve HTTP/2 flow control defaults#6240
Open
arnabnandy7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
Member
|
can you check what are the defaults in other libraries ? |
Author
checking |
Author
|
@vietj I checked a few other implementations:
Since Vert.x does not currently auto-tune the window, I used a larger static default to avoid repeatedly stalling on 64 KiB updates. The 1 MiB stream window is consistent with gRPC-Java. The 16 MiB connection window was intended to allow several concurrent streams to make progress, but it might be better to use 1 MiB there as well for closer alignment with the other implementations. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Large HTTP/2 request bodies, such as 10 MiB+ gRPC unary messages, can be extremely slow because the server uses the HTTP/2 protocol-default 65,535-byte stream and connection flow-control windows.
This change increases the server-side default stream window to 1 MiB and the connection window to 16 MiB, allowing large requests and concurrent streams to make progress with fewer flow-control update cycles. It also documents the distinction between stream-level and connection-level flow control and adds tests for the new defaults.
Client-side defaults remain unchanged.
Fixes #6238
Conformance:
I have signed the Eclipse Contributor Agreement and confirm that this contribution adheres to the Vert.x code style guidelines.