Hoist loop-invariant location strings out of validation loops - #152
Open
jnbdz wants to merge 1 commit into
Open
Conversation
The validator rebuilt schema/base/instance location prefixes such as schemaLocation + "/anyOf/" on every loop iteration. Hoist the loop-invariant concatenations in front of the loops and reuse the encoded property key where it was computed several times per iteration. No behavior change. Fixes eclipse-vertx#75
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75
Motivation
As reported in #75,
SchemaValidatorImpl.validaterebuilt loop-invariant location strings (schemaLocation + "/anyOf/" + i,instanceLocation + "/" + Pointers.encode(key), …) on every iteration of its validation loops — the hot path for large instances. The codebase had already started this pattern in one spot (keywordLocation2in theadditionalItemsloop).Changes
anyOf/allOf/oneOf,propertyNames,dependentSchemas,dependencies,properties,patternProperties,additionalProperties,unevaluatedProperties,prefixItems,items,additionalItems,contains,unevaluatedItems).Pointers.encode(key)result where it was computed up to three times per iteration.No behavior change; the full suite (including the official test-suite TCK) passes unchanged.
Note
While making this change I noticed the
containsloop iterates withjbut builds its instance location from the outeri(instanceLocation + "/" + i). This looks like a pre-existing bug in the reported error location; this PR deliberately preserves the current behavior. Happy to file/fix it separately if you agree it's wrong.