New merge of rileys discovery work - #9
Open
davidraker wants to merge 19 commits into
Open
davidraker wants to merge 19 commits into
davidraker wants to merge 19 commits into
Conversation
… functions and update entry points
…between 3.10 and 4.0
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-pre-merge # Conflicts: # pyproject.toml
Contributor
|
Looks good to me. |
…y_work New merge of rileys discovery work
shwethanidd
self-requested a review
July 29, 2026 21:52
…e_of_rileys_discovery_work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new BACnet network scanning tool, updates dependencies, and improves compatibility and usability for BACnet device discovery. The most significant changes include the introduction of a modernized
bacnet-scanscript using BACpypes3 and asyncio, enhancements to dependency management, and improved configuration flexibility.New BACnet network scanning tool:
src/protocol_proxy/protocol/bacnet/tools/scan.pythat performs WHO-IS discovery of BACnet devices using BACpypes3 and asyncio. This tool is backward compatible with the legacy script, supports both broadcast and unicast scans, allows exporting results to CSV, and provides flexible configuration via INI files or command-line arguments.Dependency and packaging improvements:
psutilas a required dependency and registered two new CLI entry points (bacnet-scanandbacnet-grab-config) inpyproject.tomlfor easier tool invocation."python_version = \">=3.10,<4.0\""for better compatibility.Configuration and documentation updates:
README.mdto use the correct package name (protocol-proxy-bacnet).BACnet protocol bugfix:
bacnet.pywhere the standard BACpypes3who_iscall incorrectly used the broadcast address instead ofNonefor broadcast, improving scan reliability.